Skip to content

[DONOTMERGE] Port ROIPool to use the Dispatcher and support Autocast #2911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
datumbox wants to merge 6 commits into from
Closed

[DONOTMERGE] Port ROIPool to use the Dispatcher and support Autocast #2911

datumbox wants to merge 6 commits into from

Conversation

@datumbox
Copy link
Contributor

@datumbox datumbox commented Oct 27, 2020 •
edited
Loading

Changes moved to #2922

@codecov
Copy link

codecov bot commented Oct 28, 2020 •
edited
Loading

Codecov Report

Merging #2911 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2911   +/-   ##
=======================================
  Coverage   73.41%   73.41%           
=======================================
  Files          99       99           
  Lines        8801     8801           
  Branches     1389     1389           
=======================================
  Hits         6461     6461           
  Misses       1915     1915           
  Partials      425      425

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fe1e11...bfe9bbc. Read the comment docs.

@datumbox datumbox force-pushed the feature/dispatcher_roipool branch from 6e0cc4e to bfe9bbc Compare October 28, 2020 11:49
@datumbox datumbox changed the title [WIP] Port ROIPool to use the Dispatcher and support Autocast Port ROIPool to use the Dispatcher and support Autocast Oct 28, 2020
@datumbox datumbox requested a review from fmassa October 28, 2020 12:35
datumbox
datumbox commented Oct 28, 2020
View reviewed changes
torchvision/csrc/cpu/ROIPool_cpu.cpp
const float spatial_scale,
const int pooled_height,
const int pooled_width) {
const double spatial_scale,
Copy link
Contributor Author

@datumbox datumbox Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fairly confident the change from float to double is the right call here, but I would like a second opinion on whether there is any unforeseen consequence due to the template definition of RoIPoolForward(.

cc @fmassa @mthrok

@datumbox datumbox mentioned this pull request Oct 28, 2020
Merged
@datumbox datumbox changed the title Port ROIPool to use the Dispatcher and support Autocast [DONOTMERGE] Port ROIPool to use the Dispatcher and support Autocast Oct 30, 2020
@datumbox datumbox closed this Oct 30, 2020
@datumbox datumbox deleted the feature/dispatcher_roipool branch October 30, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmassa fmassa Awaiting requested review from fmassa

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@datumbox